Skip to content

Latest commit

 

History

History
106 lines (84 loc) · 4.36 KB

README.md

File metadata and controls

106 lines (84 loc) · 4.36 KB
Raw

Nixpkgs pkgs/by-name checker

This directory implements a program to check the validity of the pkgs/by-name Nixpkgs directory once introduced. It is being used by this GitHub Actions workflow. This is part of the implementation of RFC 140.

API

This API may be changed over time if the CI workflow making use of it is adjusted to deal with the change appropriately.

  • Command line: nixpkgs-check-by-name <NIXPKGS>
  • Arguments:

    • <NIXPKGS>: The path to the Nixpkgs to check

    • --version <VERSION>: The version of the checks to perform.

      Possible values:

      • v0 (default)
      • v1

      See validation for the differences.

  • Exit code:
    • 0: If the validation is successful
    • 1: If the validation is not successful
    • 2: If an unexpected I/O error occurs
  • Standard error:
    • Informative messages
    • Error messages if validation is not successful

Validity checks

These checks are performed by this tool:

File structure checks

  • pkgs/by-name must only contain subdirectories of the form ${shard}/${name}, called package directories.
  • The name's of package directories must be unique when lowercased
  • name is a string only consisting of the ASCII characters a-z, A-Z, 0-9, - or _.
  • shard is the lowercased first two letters of name, expressed in Nix: shard = toLower (substring 0 2 name).
  • Each package directory must contain a package.nix file and may contain arbitrary other files.

Nix parser checks

  • Each package directory must not refer to files outside itself using symlinks or Nix path expressions.

Nix evaluation checks

  • pkgs.${name} is defined as callPackage pkgs/by-name/${shard}/${name}/package.nix args for some args.
    • Only after --version v1: If pkgs.${name} is not auto-called from pkgs/by-name, args must not be empty
  • pkgs.lib.isDerivation pkgs.${name} is true.

Development

Enter the development environment in this directory either automatically with direnv or with

nix-shell

Then use cargo:

cargo build
cargo test
cargo fmt
cargo clippy

Tests

Tests are declared in ./tests as subdirectories imitating Nixpkgs with these files:

  • default.nix: Always contains

    import ../mock-nixpkgs.nix { root = ./.; }

    which makes

    nix-instantiate <subdir> --eval -A <attr> --arg overlays <overlays>

    work very similarly to the real Nixpkgs, just enough for the program to be able to test it.

  • pkgs/by-name: The pkgs/by-name directory to check.

  • all-packages.nix (optional): Contains an overlay of the form

    self: super: {
  # ...
}

    allowing the simulation of package overrides to the real pkgs/top-level/all-packages.nix. The default is an empty overlay.

  • expected (optional): A file containing the expected standard output. The default is expecting an empty standard output.

Hydra builds

This program will always be available pre-built for x86_64-linux on the nixos-unstable channel and nixos-XX.YY channels. This is ensured by including it in the tested jobset description in nixos/release-combined.nix.

This allows CI for PRs to development branches master and release-XX.YY to fetch the pre-built program from the corresponding channel and use that to check the PR. This has the following benefits:

  • It allows CI to check all PRs, even if they would break the CI tooling.
  • It makes the CI check very fast, since no Nix builds need to be done, even for mass rebuilds.
  • It improves security, since we don't have to build potentially untrusted code from PRs. The tool only needs a very minimal Nix evaluation at runtime, which can work with readonly-mode and restrict-eval.
  • It allows anybody to make updates to the tooling and for those updates to be automatically used by CI without needing a separate release mechanism.

The tradeoff is that there's a delay between updates to the tool and those updates being used by CI. This needs to be considered when updating the API.