Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarpviz is not compiled in robotology-superbuild #987

Closed
traversaro opened this issue Jan 7, 2022 · 6 comments
Closed

yarpviz is not compiled in robotology-superbuild #987

traversaro opened this issue Jan 7, 2022 · 6 comments

Comments

@traversaro
Copy link
Member

The yarpviz tool is a useful tool, but at the moment it is not compiled if one follows the default robotology-superbuild instructions. As yarp enables it by default the YARP_COMPILE_yarpviz option if the graphviz library is installed and found (see https://github.com/robotology/yarp/blob/55ebea902ab1235e3b588e5d9eca9257a7ef6180/cmake/YarpFindDependencies.cmake#L563), probably a good trade-off is just to install graphviz as a dependency, without specifying additional options.

@traversaro
Copy link
Member Author

Probably we were not doing this as graphviz was missing in vcpkg, but considering that we are slowly dropping vcpkg as a way of installing dependency, and graphviz is now available thanks to @Ace314159 (see microsoft/vcpkg#20564), we probably can enable it now.

@traversaro
Copy link
Member Author

Note that on conda builds, graphviz was already included as a transitive dependency of gazebo, but in CI builds the yarpviz was still not building with this output:

2022-01-07T02:29:48.6151965Z --  [ ]     Compile yarpviz (dependencies unsatisfied: "YARP_HAS_Graphviz;YARP_HAS_QGVCore") (YARP_COMPILE_yarpviz)

@traversaro
Copy link
Member Author

At a first glance to the CI output, the issue is now solved for apt, but is still existing for conda. I did not check for vcpkg or brew due to #842 and https://github.com/robotology/robotology-superbuild/blob/master/doc/deprecated-installation-methods.md .

@traversaro
Copy link
Member Author

At a first glance to the CI output, the issue is now solved for apt, but is still existing for conda. I did not check for vcpkg or brew due to #842 and https://github.com/robotology/robotology-superbuild/blob/master/doc/deprecated-installation-methods.md .

I forgot about this, but the conda issue should be solved by robotology/ycm-cmake-modules#389 (and perhaps propagate it to https://github.com/robotology/yarp/blob/master/extern/qgv/qgv/cmake/modules/FindGraphviz.cmake ?).

@traversaro
Copy link
Member Author

Fixed by #1077 . The first release for which this will be fixed is 2022.02.1 .

@traversaro
Copy link
Member Author

(and perhaps propagate it to https://github.com/robotology/yarp/blob/master/extern/qgv/qgv/cmake/modules/FindGraphviz.cmake ?).

This was not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant