Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YarpOpenraveBase bugs regarding open command #69

Open
jgvictores opened this issue Jan 12, 2018 · 4 comments
Open

YarpOpenraveBase bugs regarding open command #69

jgvictores opened this issue Jan 12, 2018 · 4 comments

Comments

@jgvictores
Copy link
Member

Discovered during #67, YarpOpenraveBase only send open with the --orPlugin parameter:

std::stringstream cmdin,cmdout;
cmdin << "open";
// RAVELOG_INFO("%s\n",cmdin.str().c_str());
if( ! pModule->SendCommand(cmdout,cmdin) )
{
CD_ERROR("Bad send 'open' command.\n");
return false;
}

This may be intentional. The --orPlugins parameter is more powerful and apparently does pass more parameters. Check this.

@jgvictores
Copy link
Member Author

jgvictores commented Jan 24, 2018

Should also fix the fact that commands like these send strange commands (including dummyProgramName in name parameter):

OpenraveYarpPluginLoader = RaveCreateModule(env,'OpenraveYarpPluginLoader')
print OpenraveYarpPluginLoader.SendCommand('open --device RobotServer --subdevice YarpOpenraveRobotManager --robotIndex 0 --physics ode')
print OpenraveYarpPluginLoader.SendCommand('open --device grabber --subdevice YarpOpenraveGrabber --robotIndex 0 --sensorIndex 1 --name /ecroSim/img:o')

@jgvictores jgvictores changed the title YarpOpenraveBase only sends open with the --orPlugin parameter YarpOpenraveBase bugs regarding open command Jan 24, 2018
@jgvictores
Copy link
Member Author

This in fact looks easy to fix; a simple clear before first push_back.

@jgvictores
Copy link
Member Author

This in fact looks easy to fix; a simple clear before first push_back.

Better fix for the strange commands implemented and working at 68978df.

jgvictores added a commit that referenced this issue Feb 9, 2018
@jgvictores
Copy link
Member Author

Updated example at 6ece239.

Leaving issue open to check initial statement (singular --orPlugin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant