-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats Socket breaks with Boost 1.87 #988
Comments
Example of the build error: [ 93%] Building CXX object plugins/stat_socket/CMakeFiles/stat_socket.dir/stat_socket.cc.o
In file included from /Users/luke/Projects/TrunkRecorder/trunk-recorder/plugins/stat_socket/stat_socket.cc:6:
In file included from /Users/luke/Projects/TrunkRecorder/trunk-recorder/lib/websocketpp/config/asio_no_tls_client.hpp:32:
In file included from /Users/luke/Projects/TrunkRecorder/trunk-recorder/lib/websocketpp/transport/asio/endpoint.hpp:32:
/Users/luke/Projects/TrunkRecorder/trunk-recorder/lib/websocketpp/transport/asio/connection.hpp:89:24: error: no type named 'io_service' in namespace 'websocketpp::lib::asio'
89 | typedef lib::asio::io_service * io_service_ptr;
| ~~~~~~~~~~~^
/Users/luke/Projects/TrunkRecorder/trunk-recorder/lib/websocketpp/transport/asio/connection.hpp:91:40: error: no member named 'io_service' in namespace 'websocketpp::lib::asio'
91 | typedef lib::shared_ptr<lib::asio::io_service::strand> strand_ptr;
| ~~~~~~~~~~~^
/Users/luke/Projects/TrunkRecorder/trunk-recorder/lib/websocketpp/transport/asio/connection.hpp:315:17: error: no matching constructor for initialization of 'lib::asio::steady_timer' (aka 'basic_waitable_timer<chrono::steady_clock>')
315 | new lib::asio::steady_timer(
| ^
316 | *m_io_service,
| ~~~~~~~~~~~~~~
317 | lib::asio::milliseconds(duration)) |
asio removed some previously deprecated facilities, see https://www.boost.org/doc/libs/1_87_0/doc/html/boost_asio/history.html, this's my patch https://github.com/microsoft/vcpkg/pull/42678/files#diff-359671c6dbccd346495bb59cd5f29605921ff4c4448e6a136a89d873438b0c60 |
I think I'll also need to update the simplestream plugin due to this issue. Here's a dump from GPT that explains what needs to change. I'll put this on my to-do list for simplestream and the same changes should be able to be applied to this plugin as well, I think.
#include <boost/asio.hpp>
|
The Stats Socket plugin stops working with Boost 1.87. The WebSocket library being used ( https://github.com/zaphoyd/websocketpp ) hasn't been updated in 4 years, so it is not likely this will be fixed soon. The best option is to probably pull Stats Socket from the build for now until a new library can be slotted in.
Issue from Websocketpp repo:
zaphoyd/websocketpp#1157
The text was updated successfully, but these errors were encountered: