You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've thought the recording mode should be at least a 3 way option.
Upon termination flag (transmission end):
call is always closed, putting each transmission in a separate call (future transmissions are started based upon their grant messages by ignoring check for existing call)
(current mode) file is closed but call is kept open
Keeping the current approach - it is a good balance of keeping the number of files reasonable and not having to move file pointers around too. Happy to reconsider if there is a strong desire for this
Mentioned in #791 and is a follow up to #326
I've thought the recording mode should be at least a 3 way option.
Upon termination flag (transmission end):
To do conversation mode only involves:
end_transmission()
heretrunk-recorder/trunk-recorder/gr_blocks/transmission_sink.cc
Line 224 in e33e441
close_wav()
tostop_recording()
trunk-recorder/trunk-recorder/gr_blocks/transmission_sink.cc
Line 257 in e33e441
end_transmission()
will no longer do itclose_wav()
creates a correct headertrunk-recorder/trunk-recorder/gr_blocks/transmission_sink.cc
Lines 546 to 547 in ca64f7a
transmission_sink::dowork
because on a termination flag they will not be reached due totrunk-recorder/trunk-recorder/gr_blocks/transmission_sink.cc
Line 483 in ca64f7a
Originally posted by @rosecitytransit in #791 (comment)
The text was updated successfully, but these errors were encountered: