Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for disabling conversation mode #813

Open
rosecitytransit opened this issue May 12, 2023 · 2 comments
Open

Support for disabling conversation mode #813

rosecitytransit opened this issue May 12, 2023 · 2 comments

Comments

@rosecitytransit
Copy link
Contributor

rosecitytransit commented May 12, 2023

Mentioned in #791 and is a follow up to #326

I've thought the recording mode should be at least a 3 way option.

Upon termination flag (transmission end):

  • call is always closed, putting each transmission in a separate call (future transmissions are started based upon their grant messages by ignoring check for existing call)
  • (current mode) file is closed but call is kept open
  • file is kept open and closed on call end

To do conversation mode only involves:

  1. not closing the file in end_transmission() here
  2. adding close_wav() to stop_recording()
    void transmission_sink::stop_recording() {
    since end_transmission() will no longer do it
  3. having a separate sample counter so that close_wav() creates a correct header
  4. Ignoring or removing the error messages about the file not closing/being open
  5. modifying call concluder to handle the entire call being in the first transmission file
  6. Also need to move
    d_stop_time = time(NULL);
    d_last_write_time = std::chrono::steady_clock::now();
    outside of transmission_sink::dowork because on a termination flag they will not be reached due to

Originally posted by @rosecitytransit in #791 (comment)

@robotastic
Copy link
Owner

Keeping the current approach - it is a good balance of keeping the number of files reasonable and not having to move file pointers around too. Happy to reconsider if there is a strong desire for this

@robotastic
Copy link
Owner

Actually... maybe we should enable some support for turning off conversation mode.... I will leave this open

@robotastic robotastic reopened this Dec 15, 2024
@robotastic robotastic changed the title create recording mode option Support for disabling conversation mode Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants