Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph is blurry on high DPI macOS with Qt5 #170

Open
Be-ing opened this issue Feb 7, 2022 · 6 comments
Open

graph is blurry on high DPI macOS with Qt5 #170

Be-ing opened this issue Feb 7, 2022 · 6 comments

Comments

@Be-ing
Copy link

Be-ing commented Feb 7, 2022

Environment

Steps To Reproduce

Open QJackCtl distributed with JACK on macOS and click the Graph button

Expected vs. actual behavior

The connection graph in the QJackCtl build shipped with the macOS version of JACK does not scale well for high DPI screens. Everything within the graph is blurry but the text at the top of the window scales okay:
Screen Shot 2022-02-06 at 7 36 47 PM

@rncbc
Copy link
Owner

rncbc commented Feb 7, 2022

can't argue about macosx, but the Graph scales quite well and sharply on Linux X11/Wayland (Qt6.2)

@Be-ing
Copy link
Author

Be-ing commented Feb 7, 2022

This issue does not occur with QJackCtl from Homebrew which is built with Qt 6.2.2:

Screen Shot 2022-02-07 at 8 20 27 AM

I think this can be fixed by setting the Qt::AA_EnableHighDpiScaling when building with Qt5. This was removed in Qt6; high DPI scaling is always enabled in Qt6.

@Be-ing
Copy link
Author

Be-ing commented Feb 7, 2022

The graphics are still blurry because they're all low resolution rasters.

@rncbc
Copy link
Owner

rncbc commented Feb 7, 2022

I think this can be fixed by setting the Qt::AA_EnableHighDpiScaling when building with Qt5.

maybe you wanna have a look around here:

QApplication::setAttribute(Qt::AA_EnableHighDpiScaling);

  • it's been enabled for Qt5 where applicable, and disabled for Qt6 for good measure.

@Be-ing
Copy link
Author

Be-ing commented Feb 7, 2022

Hmm, if that's already implemented then I'm nos sure what else could be the issue.

@Be-ing Be-ing changed the title graph is blurry on high DPI macOS graph is blurry on high DPI macOS with Qt5 Feb 7, 2022
@rncbc
Copy link
Owner

rncbc commented Feb 7, 2022

issue (probably) lies on an old Qt5 perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants