Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostic message for invalid yaml path #30

Open
ns-dkoblas opened this issue Sep 27, 2023 · 2 comments
Open

Improve diagnostic message for invalid yaml path #30

ns-dkoblas opened this issue Sep 27, 2023 · 2 comments

Comments

@ns-dkoblas
Copy link

In the function async function fetchContent(client: github.GitHub, repoPath: string): Promise<string> {

In the event that the YAML file is not found, you returned the following diagnostics:

HttpError: Not Found
Error: Not Found

Ideally the client.repos.getContents call is wrapped and could return / log that it was unable to load the file rather than a generic HTTP error

@rmacklin
Copy link
Owner

rmacklin commented Oct 2, 2023

Hi! I see what you mean, but just so you know, if you were to run the action with debug logging enabled, you would see this log right before that:

core.debug(`Fetching team data from ${teamDataPath}`)

which should hopefully help illustrate what was "not found". That said, if you want to open a PR with your suggested improvement, I'd be happy to consider it.

@ns-dkoblas
Copy link
Author

I ended up needing extra functionality (parent groups) and re-built a bunch of functionality while moving things to TS5. So no longer have a "simple" change.

https://github.com/infiotinc/team-sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants