Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: YML validation #18

Open
joshua-cannon-techlabs opened this issue Sep 22, 2021 · 3 comments
Open

Feature: YML validation #18

joshua-cannon-techlabs opened this issue Sep 22, 2021 · 3 comments

Comments

@joshua-cannon-techlabs
Copy link

Since this action only makes sense to run on pushes to the default branch, we don't have good validation/feedback that the YML isn't completely broken until we've already merged the PR.

I nice easy little PR check to validate the teams yml is "valid" for the action would be lovely.

@joshua-cannon-techlabs
Copy link
Author

As a workaround I think I'll write me a little validator to do just that, but it'd likely be underneath our existing umbrella testing check.

@rmacklin
Copy link
Owner

Perhaps we could add a "validate-only" parameter to the action which only parses the teams.yml file but doesn't attempt to sync changes to the GitHub organization. Then users could add a second workflow that runs on the non-default branches which invokes the team-sync action in that "validate-only" mode.

@splitice
Copy link

I agree a validate-only parameter would be a good idea. That could run on pull_request only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants