Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of PHP 8.1 deprecations warnings #11

Open
joworeiter opened this issue Feb 22, 2023 · 1 comment
Open

Get rid of PHP 8.1 deprecations warnings #11

joworeiter opened this issue Feb 22, 2023 · 1 comment

Comments

@joworeiter
Copy link
Contributor

Since the upgrade to PHP 8.1 we get a ton of deprecation warnings.
This could easily be fixed by adding return types, which are only available since 7.1, so I would advocate to set the min. php version at least to php 7.1 and fix the warnings by adding proper return types, where possible or supress them by adding the willChange-Attribute.

If someone could review my last pull request, I would be deligthed to serve an other one for this ones.

@rjjakes
Copy link
Owner

rjjakes commented Feb 23, 2023

@joworeiter I've merged your previous PR. You can raise a new PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants