Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(throttle): incorrectly usage of RateLimiter::check #19930

Closed
MrCroxx opened this issue Dec 25, 2024 · 1 comment
Closed

bug(throttle): incorrectly usage of RateLimiter::check #19930

MrCroxx opened this issue Dec 25, 2024 · 1 comment
Labels
type/bug Something isn't working
Milestone

Comments

@MrCroxx
Copy link
Contributor

MrCroxx commented Dec 25, 2024

Describe the bug

With crate governor, the RateLimiter::check function also updates the quota.

https://docs.rs/governor/latest/src/governor/state/direct.rs.html#75-82

However, in RisingWave, we are using it to check if the rate limiter can allow the current row without willing to update the quota. In this case, the real throughput is lower than expected.

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response

@MrCroxx MrCroxx added the type/bug Something isn't working label Dec 25, 2024
@github-actions github-actions bot added this to the release-2.2 milestone Dec 25, 2024
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Dec 25, 2024

Checked again. governor only upates quota when check allows the request, it is okay if we don't call until again.

@MrCroxx MrCroxx closed this as not planned Won't fix, can't repro, duplicate, stale Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant