Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support prepared statements for DDL #16653

Open
1 of 4 tasks
BugenZhao opened this issue May 9, 2024 · 1 comment
Open
1 of 4 tasks

support prepared statements for DDL #16653

BugenZhao opened this issue May 9, 2024 · 1 comment
Assignees
Labels
component/frontend Protocol, parsing, binder. type/feature

Comments

@BugenZhao
Copy link
Member

BugenZhao commented May 9, 2024

There were no technical issues blocking this. Recently we found some users requesting this feature.

Most of work have done. Remain work: create as with parameter, create view with parameter, create sink with parameter.

But I don't think it's worth to support them beacase:

Can't support ddl with param like create view v as
Actually I think it's not necessary because the param is useful for reusing a sql. But for ddl sql, it can't be reused because you can't create a view or table twice. So I think the user may rarely use ddl with param. And if we support it, it will cause the redundant and duplicate code like query handle so that it take effort to maintain or refactor them.

If this point is acceptable, this issue is done.

Originally posted by @ZENOTME in #8112 (comment)


  • create materialized view with parameter
  • create table as with parameter
  • create view with parameter
  • create sink with parameter
@github-actions github-actions bot added this to the release-1.10 milestone May 9, 2024
@BugenZhao BugenZhao added type/feature component/frontend Protocol, parsing, binder. labels May 9, 2024
@fuyufjh fuyufjh self-assigned this Jul 10, 2024
@fuyufjh
Copy link
Member

fuyufjh commented Jul 23, 2024

#17769 completes the create materialized view first because it's more useful than the rest. We may complete the rest part later if requested by any users.

@fuyufjh fuyufjh removed this from the release-1.10 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/frontend Protocol, parsing, binder. type/feature
Projects
None yet
Development

No branches or pull requests

2 participants