support redact SHOW CREATE on demand

[zwang28]

Is your feature request related to a problem? Please describe.

Sensitive properties of source/sink, e.g. s3.credentials.secret and schema.registry.password, should be redacted first before included in text that may be shared, e.g. show create source/sink/table, diagnostic report.

#12673

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

[xxchan]

How is this related with #7034?

[zwang28]

How is this related with #7034?

Pls ignore that. Previously I thought changes on persisted catalog was required, but it turns out to be wrong.

[fuyufjh]

Hi, @zwang28 any progress?

[zwang28]

Hi, @zwang28 any progress?

#14760 adds a helper function to redact a SQL string. It's under review.

With regards to its call site. I intended to:

• Always redact in diagnostic report.
• Because sometimes user does want to view the secrets, show create should be optionally redacted, e.g. only object owner can view the plain text.

[zwang28]

go for risingwavelabs/rfcs#86

[stefannegele]

As SECRETS will be premium feature (https://docs.risingwave.com/docs/dev/manage-secrets/), can we reopen this?

[xxchan]

I think we are not going to support this and you can use the premium edition.

[stefannegele]

Sad to read. At this point, it's not my decision to use the premium edition or not.

Furthermore, I think it's just bad practice to put sensitive information in logs, even for unpaid open-source software, as it prevents people from evaluating it in a productive environment.

Sorry if this sounds demanding coming from someone who uses your software for free. I really like your product and appreciate your efforts.

[mrayees]

@stefannegele Thanks for your feedback. Let me look into it.