Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the value of --etcd-password when starting meta node with arguments #13005

Closed
arkbriar opened this issue Oct 23, 2023 · 1 comment · Fixed by #13034
Closed

Hide the value of --etcd-password when starting meta node with arguments #13005

arkbriar opened this issue Oct 23, 2023 · 1 comment · Fixed by #13034
Assignees
Milestone

Comments

@arkbriar
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Meta prints the following log when I started it with etcd. I think we should hide it when printing to the log.

2023-10-23T08:51:54.600602553Z  INFO risingwave_cmd_all::standalone: starting meta-node thread with cli args: ["meta-node", "--listen-addr", "127.0.0.1:5690", "--advertise-addr", "127.0.0.1:5690", "--dashboard-host", "0.0.0.0:5691", "--prometheus-host", "0.0.0.0:1250", "--state-store", "hummock+memory", "--data-directory", "hummock", "--config-path", "/risingwave/config/risingwave.toml", "--backend", "etcd", "--etcd-endpoints", "etcd.default.svc:2379", "--etcd-auth", "--etcd-username", "root", "--etcd-password", "q2mqOcMrjU"]

Describe the solution you'd like

Hide the values with *, for example, or else omit it.

"meta-node", "--listen-addr", "127.0.0.1:5690", "--advertise-addr", "127.0.0.1:5690", "--dashboard-host", "0.0.0.0:5691", "--prometheus-host", "0.0.0.0:1250", "--state-store", "hummock+memory", "--data-directory", "hummock", "--config-path", "/risingwave/config/risingwave.toml", "--backend", "etcd", "--etcd-endpoints", "etcd.default.svc:2379", "--etcd-auth", "--etcd-username", "root", "--etcd-password", "********"

Describe alternatives you've considered

No response

Additional context

No response

@xiangjinwu
Copy link
Contributor

related: #12673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants