Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(source): ParserProperties::key_encoding_config is introduced but never used #12974

Closed
xiangjinwu opened this issue Oct 20, 2023 · 0 comments · Fixed by #17416
Closed
Assignees
Milestone

Comments

@xiangjinwu
Copy link
Contributor

It was introduced as a part of the new source DDL work, aiming to separate key and value properties. #10969

However, for backward compatibility, we still need to support reading key properties from the unified properties. So the refactor was paused.

pub struct SpecificParserConfig {
    pub key_encoding_config: Option<EncodingProperties>, // newly introduced but never used
    pub encoding_config: EncodingProperties, // unified key+value, would like to be repurposed as value-only
    pub protocol_config: ProtocolProperties,
}

The current status is misleading / confusing. We need to decide whether to revert or continue the separation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant