Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: mistakenly include file cache buffer pool size in memory calculation #12943

Closed
hzxa21 opened this issue Oct 18, 2023 · 0 comments · Fixed by #12941
Closed

bug: mistakenly include file cache buffer pool size in memory calculation #12943

hzxa21 opened this issue Oct 18, 2023 · 0 comments · Fixed by #12941
Labels
type/bug Something isn't working
Milestone
release-1.4

Comments

@hzxa21
Copy link
Collaborator

hzxa21 commented Oct 18, 2023

Describe the bug

Since we introduce proportion to setup memory limits in #8630, the file cache buffer capacity (recently renamed as buffer pool) is included in storage memory calculation regardless of whether file cache is enabled or not. This will cause around 800MB non-reserved memory not being used by any component.

#12941 fixes the issue.

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response
@hzxa21 hzxa21 added the type/bug Something isn't working label Oct 18, 2023
@github-actions github-actions bot added this to the release-1.4 milestone Oct 18, 2023
@MrCroxx MrCroxx mentioned this issue Oct 18, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something isn't working
Projects
None yet
Milestone
release-1.4
Development

Successfully merging a pull request may close this issue.

fix: don't count file cache buffer pool size if disabled risingwavelabs/risingwave
1 participant
@hzxa21