Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: refactor binder and planner #694

Open
skyzh opened this issue Sep 29, 2022 · 0 comments
Open

RFC: refactor binder and planner #694

skyzh opened this issue Sep 29, 2022 · 0 comments

Comments

@skyzh
Copy link
Member

skyzh commented Sep 29, 2022

Let's borrow some code from https://github.com/cmu-db/bustub

  • For binder, we have too many local states, which are hard to track. e.g., for a BindXXX function, we should return a BoundXXX, instead of recording something inside the binder and use it later. This is prune to error.
  • For planner, we should have a separate expression enum type. binder: separate InputRef to another expression type #693
  • We should have schema for each plan node from day one. Wrong schema is causing too many problems for us. The next refactoring should also enforce schema on all plan nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant