Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Merge with 7-Year-Old Fork? #33

Open
petermarkley opened this issue Jun 10, 2022 · 2 comments
Open

Re-Merge with 7-Year-Old Fork? #33

petermarkley opened this issue Jun 10, 2022 · 2 comments

Comments

@petermarkley
Copy link

petermarkley commented Jun 10, 2022

Hello Mr. Risacher, and welcome back!

Back in 2015, someone forked your project on Github here: https://github.com/klada/sunwait

Since this new maintainer was more responsive at the time, I submitted to him my DST bug fix from 2018. I also recommended a change of upstream to the maintainers of Macports: https://trac.macports.org/ticket/57657

I suppose we should compare the best changes across both repos and settle on an authoritative maintainer again?

If that's you, we should tell the Macports people again.

Thanks!

@petermarkley
Copy link
Author

petermarkley commented Jun 10, 2022

Oh, and while you compare repos you might want to take a very close look at this: klada/sunwait#3

I'm looking at sunwait.cpp:439 and thinking that you maybe fixed only one of the two bugs that I found in 2018 (the one mentioned here). The other one was in getUtcBiasHours(), and looks unfixed in your code.

I can't test right now to verify if I'm correct.

Notice also that in my pull request on the other repo, I changed a variable name to remove the false assumption of UTC in the code logic.

@petermarkley
Copy link
Author

I told the maintainer of the other repo. He archived his repo and added a link to yours.

When I get time, I'll try to create a pull request here that fixes the bug in getUtcBiasHours() again.

It's just the one line of code, sunwait.cpp:439 ... But since there may be changes elsewhere in the code, I need to re-test it all. (With DST, that means testing on a device where I can change the system clock without concern. 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant