Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors lag after change of Variable or Base map in GreatLakes_Dashboard #7

Open
hdsingh opened this issue Apr 26, 2019 · 6 comments
Open

Comments

@hdsingh
Copy link
Contributor

hdsingh commented Apr 26, 2019

The colors seem to lag by one after changing the Model Variables or Basemap i.e the color of location marker does not match its corresponding line color. I am trying to figure out the reason behind this. I have also tried to replace the get_line_color with color_stream but the behaviour still persists. Can you please look into this and help me understand why this might be happening?

@rsignell-usgs
Copy link
Member

@hdsingh, who were you hoping would look into this?

@hdsingh
Copy link
Contributor Author

hdsingh commented Apr 30, 2019

I was hoping if any one you, @martindurant or @jsignell could help me figure this out. Thanks for letting me know. From next time I would be careful in directly mentioning those who can help.

@martindurant
Copy link

Sorry, could you perhaps describe what you are seeing in a bit more detail? Which notebook and and what point? Perhaps a screenshot might be appropriate. If it's a genuine issue, it might be appropriate to report at Panel or Holoviews.

@hdsingh
Copy link
Contributor Author

hdsingh commented May 1, 2019

@rsignell-usgs @martindurant Here is more detail of the issue. Please let me know if anything else is required.

The issue is in GreatLakes_Dashboard. The dashboard formed works well initially. However when we change anyone of Model Variables or Basemap, lag of color of a point from its respective line starts.

Initially , when color sync is perfect (Model variable is zeta):
1

but later on (Model variable is temp):

2
The color points are displayed in order of orange, yellow,blue while the time series lines are displayed in order of red, orange, yellow.
Red is the color provided in the exception in get_line_color function which is being triggered.

One thing to note here is that before variable change, location points are displayed just a little ahead of displaying time series curve while later on, the time series curve is displayed early as compared to the location points.

I am unable to find the reason because of which it does not runs well on changing the varibles.

Also the generated time series map does not automatically adjusts itself. We need to zoom out manually to see all the lines.

@rsignell-usgs
Copy link
Member

rsignell-usgs commented May 1, 2019

Also the generated time series map does not automatically adjusts itself. We need to zoom out manually to see all the lines.

@hdsingh, let's try to not mix issues. I encountered this as well.

Can you please raise this as a new issue?

@hdsingh
Copy link
Contributor Author

hdsingh commented May 1, 2019

Yes sir, here is the separate issue regarding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants