New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Github access tokens #35

Open

simon-isler opened this issue Dec 10, 2024 · 1 comment

Assignees

Member

simon-isler commented Dec 10, 2024

Currently, the plugin does not check whether the passed Github PAT is still valid or not. I think it would make sense to add a check in

Lines 6 to 11 in 4406783

    
           def check_env 
        
             ENV['GITHUB_WEBHOOK_SECRET'].present? || 
        
               ENV['GITHUB_ACCESS_TOKEN'].present? || 
        
               ENV['SEMAPHORE_WEBHOOK_SECRET'].present? || 
        
               ENV['GITHUB_ORGANIZATION_NAME'].present? 
        
           end

and abort if it can't be used to authorize.

simon-isler assigned CuddlyBunion341

Contributor

CuddlyBunion341 commented Dec 10, 2024

https://renuo.slack.com/archives/CSWBT1WLA/p1733758092424389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment