Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully close long-lived connections to backing services when processes end #339

Open
gnarea opened this issue Dec 18, 2020 · 0 comments
Labels
artefact/docker-image Related to the Docker Image enhancement New feature or request

Comments

@gnarea
Copy link
Member

gnarea commented Dec 18, 2020

Fastify helps with this with an onClose hook which the Mongoose plugin uses, but we're not currently calling fastify.close() following a SIGINT/SIGTERM. https://github.com/hemerajs/fastify-graceful-shutdown can do that for us, but it's a bit of an overkill and has some caveats (as mentioned in the README).

All other processes (i.e., the gRPC server and background queues) don't currently offer a way to release resources upon process termination, so we'll have to implement something custom.

@gnarea gnarea added enhancement New feature or request artefact/docker-image Related to the Docker Image labels Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artefact/docker-image Related to the Docker Image enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant