-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public VLAN deployment for SNO clusters #576
base: main
Are you sure you want to change the base?
Conversation
rsevilla87
commented
Dec 3, 2024
- closes [RFE] Public VLAN in SNO deployments #575
Signed-off-by: Raul Sevilla <[email protected]>
/test ? |
@rsevilla87: The following commands are available to trigger required jobs:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…eway variables Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josecastillolema, rsevilla87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Signed-off-by: Raul Sevilla <[email protected]>
New changes are detected. LGTM label has been removed. |
@@ -31,11 +42,11 @@ bmc_password={{ bmc_password }} | |||
{%- if use_bastion_registry -%} | |||
{%- set ip=controlplane_network | ansible.utils.nthhost(loop.index0 + 5) -%} | |||
{%- elif public_vlan | bool -%} | |||
{%- set ip=controlplane_pub_network_cidr | ansible.utils.nthhost(loop.index0 + 1) -%} | |||
{%- set ip=controlplane_network | ansible.utils.nthhost(loop.index0 + 3) -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating this expression to pick the 3rd IP of the subnet, which is the one that has the API DNS entry, for example:
$ dig api.vlan101.rdu3.labs.perfscale.redhat.com +shor
10.6.128.3