Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public VLAN deployment for SNO clusters #576

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rsevilla87
Copy link
Member

@rsevilla87
Copy link
Member Author

/test ?

Copy link

openshift-ci bot commented Dec 9, 2024

@rsevilla87: The following commands are available to trigger required jobs:

/test deploy-5nodes
/test deploy-5nodes-dev
/test deploy-sno
/test deploy-sno-dev

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josecastillolema, rsevilla87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [josecastillolema,rsevilla87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josecastillolema
Copy link
Collaborator

/hold

Signed-off-by: Raul Sevilla <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 13, 2024
Copy link

openshift-ci bot commented Dec 13, 2024

New changes are detected. LGTM label has been removed.

@@ -31,11 +42,11 @@ bmc_password={{ bmc_password }}
{%- if use_bastion_registry -%}
{%- set ip=controlplane_network | ansible.utils.nthhost(loop.index0 + 5) -%}
{%- elif public_vlan | bool -%}
{%- set ip=controlplane_pub_network_cidr | ansible.utils.nthhost(loop.index0 + 1) -%}
{%- set ip=controlplane_network | ansible.utils.nthhost(loop.index0 + 3) -%}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this expression to pick the 3rd IP of the subnet, which is the one that has the API DNS entry, for example:

$ dig api.vlan101.rdu3.labs.perfscale.redhat.com +shor
10.6.128.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Public VLAN in SNO deployments
2 participants