Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3.18 textDocument/inlineCompletion #643

Open
rcjsuen opened this issue Nov 29, 2024 · 8 comments
Open

Add support for 3.18 textDocument/inlineCompletion #643

rcjsuen opened this issue Nov 29, 2024 · 8 comments
Labels
enhancement New feature or request inlineCompletion

Comments

@rcjsuen
Copy link

rcjsuen commented Nov 29, 2024

No description provided.

@angelozerr
Copy link
Contributor

It would be nice but do you know some language server which supports this feature?

@rcjsuen
Copy link
Author

rcjsuen commented Nov 29, 2024

It would be nice but do you know some language server which supports this feature?

None that I am aware of but I am currently investigating the feature and noticed it wasn't on the list hence I asked.

@angelozerr
Copy link
Contributor

I think we should have a language server usecase to implement it

@angelozerr
Copy link
Contributor

Have you the intention to contribute to lsp4ij with this lsp inline completion ?

I believe that IJ provides an extension point which manages this inline completion

@SCWells72
Copy link
Contributor

I believe that IJ provides an extension point which manages this inline completion

It does provide such an EP, inline.completion.provider. Note that there are two considerations regarding that EP, though. First, it's a quite recent addition and, if memory serves, it's not available in some of the older IDE versions still supported by LSP4IJ. Second, it must be implemented in Kotlin.

@rcjsuen
Copy link
Author

rcjsuen commented Dec 5, 2024

Have you the intention to contribute to lsp4ij with this lsp inline completion ?

Don't think I'll be able to dedicate time to this given my current priorities. I also haven't written Java in ten years and don't know anything about Kotlin... 🤔

@angelozerr angelozerr added enhancement New feature or request inlineCompletion labels Dec 7, 2024
@angelozerr
Copy link
Contributor

Ok no problem.

My guess is that you are using user defined language server znd not a custom IJ plugin, right?

If it that I suggest that you add your docker language server as template in lsp4ij like I did for sourcekit lsp #642

I am working to associate a json schema to the configuration server to have completion validation for settingd.

@rcjsuen
Copy link
Author

rcjsuen commented Dec 9, 2024

My guess is that you are using user defined language server znd not a custom IJ plugin, right?

At the moment since I am still in the testing phase. However, a decent number of my colleagues use GoLand so a plug-in is certainly on my mind.

If it that I suggest that you add your docker language server as template in lsp4ij like I did for sourcekit lsp #642

Thank you for the reference! That certainly seems like something that might be worth investigating for my open source project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request inlineCompletion
Projects
None yet
Development

No branches or pull requests

3 participants