Improve window/showMessageRequest client capability

[rcjsuen]

Our language server uses windows/showMessageRequest to ask the user something. It would be nice if the LSP4IJ client library supported this LSP request. Thanks!

[fbricon]

Should be already supported https://github.com/redhat-developer/lsp4ij/blob/main/docs/LSPSupport.md#show-message-request

[rcjsuen]

Should be already supported https://github.com/redhat-developer/lsp4ij/blob/main/docs/LSPSupport.md#show-message-request

{
  "capabilities": {
    "window": {
      "workDoneProgress": true,
      "showMessage": {},
      "showDocument": {
        "support": true
      }
    }
  }
}

/**
 * Show message request client capabilities
 */
export interface ShowMessageRequestClientCapabilities {
	/**
	 * Capabilities specific to the `MessageActionItem` type.
	 */
	messageActionItem?: {
		/**
		 * Whether the client supports additional attributes which
		 * are preserved and sent back to the server in the
		 * request's response.
		 */
		additionalPropertiesSupport?: boolean;
	};
}

The payload confused me as I was expecting "showMessage": { "messageActionItem": {} } but I think "showMessage": {} is reasonable for suggesting it supports both window/showMessage and window/showMessageRequest when I look at it again. 🤔

[angelozerr]

Should be already supported https://github.com/redhat-developer/lsp4ij/blob/main/docs/LSPSupport.md#show-message-request

{
  "capabilities": {
    "window": {
      "workDoneProgress": true,
      "showMessage": {},
      "showDocument": {
        "support": true
      }
    }
  }
}

/**
 * Show message request client capabilities
 */
export interface ShowMessageRequestClientCapabilities {
	/**
	 * Capabilities specific to the `MessageActionItem` type.
	 */
	messageActionItem?: {
		/**
		 * Whether the client supports additional attributes which
		 * are preserved and sent back to the server in the
		 * request's response.
		 */
		additionalPropertiesSupport?: boolean;
	};
}

The payload confused me as I was expecting "showMessage": { "messageActionItem": {} } but I think "showMessage": {} is reasonable for suggesting it supports both window/showMessage and window/showMessageRequest when I look at it again. 🤔

What about vscode?

[rcjsuen]

What about vscode?

They go "all the way" so there's no ambiguity.

{
    "capabilities": {
        "window": {
            "showMessage": {
                "messageActionItem": {
                    "additionalPropertiesSupport": true
                }
            },
            "showDocument": {
                "support": true
            },
            "workDoneProgress": true
        }
    }
}

[angelozerr]

It is managed here
https://github.com/redhat-developer/lsp4ij/blob/main/src%2Fmain%2Fjava%2Fcom%2Fredhat%2Fdevtools%2Flsp4ij%2Finternal%2FClientCapabilitiesFactory.java#L282

Any contribution are welcome.

[angelozerr]

@rcjsuen to know what LSP features are supported in LSP4IJ, please read https://github.com/redhat-developer/lsp4ij/blob/main/docs/LSPSupport.md