Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Green note gets removed when exporting #320

Open
NicolasPL64 opened this issue Apr 1, 2022 · 1 comment
Open

Green note gets removed when exporting #320

NicolasPL64 opened this issue Apr 1, 2022 · 1 comment

Comments

@NicolasPL64
Copy link

When I export a chart with extended opens where there's a green note, the green notes get deleted ONLY in the midi file, the .eof file still saves the green notes as you can see here:

.eof file:
image

.midi file after exporting:
image

This only happens with green notes and when they're over an open note.
Here are both files just in case: notes.zip

@RoscoeSmith
Copy link
Contributor

This is an issue with how EOF handles open notes. It treats them as a green note and creates a sysex event that tells games like Clone Hero to them as open instead of green. As a result, when exporting, EOF overwrites any green notes that overlap with an extended open, since it considers them both to be green notes.
Clone Hero has a fix for this. If a text event with the text [ENHANCED_OPENS] is present at the start of a track, it will look for all midi notes one below the standard green note and treat them as open notes, allowing the extended opens and green notes to coexist. For Expert difficulty, this would be midi note 95.
EOF does not currently support the enhanced opens tag, so you would need to add the open notes in manually using a midi editor (I believe Moonscraper supports it as well).
I've already implemented the functionality myself and will create a pull request shortly to hopefully roll it into the main build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants