Trailing % signs after addresses when setting RHOSTS via service command

[rtpt-erikgeiser]

When the database contains hosts with empty scope columns (where scope is an empty string instead of nil), they are not correctly added to RHOSTS via services -R because the command adds a trailing % sign to each address. This can happen if the database is filled by an external program that sets scope to an empty string instead of NULL.

Steps to reproduce

Make sure you have less then 5 hosts in the database (or add a filter that reduces the number of hits to less than 5) and make sure that the hosts have empty strings in their scope column and not NULL.

1. msfconsole
2. services -R

Expected behavior

Unscoped addresses in RHOSTS should not have trailing % signs.

Current behavior

Now you see that the addresses in RHOSTS have trailing % signs. These are normally added to separate the address scope but in this case the scope is empty and they are added regardless.

Metasploit version

6.3.36

Additional Information

Fixed by #18411.