Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_tls_stream_integration sometimes timeout #4360

Open
omnivagant opened this issue Oct 8, 2024 · 1 comment
Open

test_tls_stream_integration sometimes timeout #4360

omnivagant opened this issue Oct 8, 2024 · 1 comment
Labels

Comments

@omnivagant
Copy link

In AlpineLinux we noticed that parts of this test would sometimes timeout on some architectures, most often loongarch64 and riscv64:

tls_stream_integration:
Server ran 44 tests 3 FAILED
Failure 1: Server: timeout in accept
Failure 2: Server: timeout in accept
Failure 3: Server: timeout in accept

Raising this timeout helps:

--- a/src/tests/test_tls_stream_integration.cpp
+++ b/src/tests/test_tls_stream_integration.cpp
@@ -33,7 +33,7 @@ using ssl_stream = Botan::TLS::Stream<ne
 using namespace std::placeholders;
 using Result = Botan_Tests::Test::Result;
 
-static const auto k_timeout = std::chrono::seconds(3);
+static const auto k_timeout = std::chrono::seconds(6);
 static const auto k_endpoints = std::vector<tcp::endpoint> {tcp::endpoint{net::ip::make_address("127.0.0.1"), 8082}};
 
 enum { max_msg_length = 512 };
@randombit randombit added the bug label Oct 9, 2024
@reneme
Copy link
Collaborator

reneme commented Oct 11, 2024

I'm assuming you are using Botan 2.x, right? During the development of TLS 1.3 in Botan 3.x we raised this timeout (and improved the steering of this test case), because we saw a similar flaky behavior in our CI.

@randombit Should we backport this, perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants