This has a pretty big impact in our usage of radix-ui. We have slowly been migrating from MUI to Radix, and we've recently noticed severe performance degradation. We could easily reproduce this memory leak, and we use dialog workflows quite extensively, this is therefore an urgent issue for us.

If anyone has a workaround we could patch or apply that'd be highly appreciated. We will look for one in the meantime.

We may need to revert to alternative dialog solutions in the short term if this issue is not picked up.

Hi, I have tried to set the Dailog with modal={false}, I keep opening it several times, the memory is not going higher anymore.

This is indeed a serious problem, as I got hundreds of MB of memory used when opening the Dialog (modal={true} by default) many times later.

This is how I use the current Dialog (for shadcn/ui):

https://codesandbox.io/p/sandbox/radix-ui-primitives-issues-3202-jzd42z

use modal={false} and custom Overlay to simulate the effect.

It seems that this does not cause the memory leak by doing so.

Any feedback would be greatly appreciated! As this is just quick workaround.

I can't get the garbage collector to remove all of the dialog nodes in your example either @Lexachoc.

It is easy to reproduce if I type something in one of the input fields before closing the dialog.

@Kjetiljv Thank you for pointing out! I only looked at the Permance monitor for the JS heap size and DOM nodes and taking snapshots for comparasion.

First time using it. Not sure how badly is the memory leak of my example. Could you please enlighten me if my example's memory leak situation better?The input fields are already there. Would retyping do anything about the memory leak?

This is from the original example:

And this is from my example:

both are reopened multiple time.

@Lexachoc, sorry I should have formulated myself better.

Your example seems to produce fewer dom nodes when I open and close the dialogg without making a change to its content. But if I type something in one of the input fields it will continue to grow. I made a video that I hope will explain it better.

FYI - this behavior is reproducable with Radix Popover as well, but not as consistently.

And with Tooltips – every hover leaves around a detached element that doesn't get garbage collected.

Easily reproducible here: https://www.radix-ui.com/primitives/docs/components/tooltip

@lauri865 fantastic with a fix pending 👏

Is there any chance for us to patch this sooner rather than later? Any ETA on when we'll see this in a released version?

That's up to the maintainers when they have time to review and release the next version.

For the time being, since it's a simple one-line fix, you can patch @radix-ui/react-presence locally – we have done so for now. Either with pnpm if you use that or alternatively with https://www.npmjs.com/package/patch-package

@lauri865 thanks - that makes sense. This is quite urgent for us, will have a look at your suggestions 👍