Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill language gaps #1688

Closed
danielmarbach opened this issue Sep 26, 2024 · 3 comments
Closed

Polyfill language gaps #1688

danielmarbach opened this issue Sep 26, 2024 · 3 comments
Assignees

Comments

@danielmarbach
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Until #1424 is resolved, the library seems to target Netstandard2.0. If I understood the discussion correctly for v8 the team is willing to rediscuss the TFMs. Until then, is it reasonable to Polyfill language gaps with something like https://github.com/Sergio0694/PolySharp or https://github.com/SimonCropp/Polyfill/ (my preference but would require LangVersion=latest)? This would allow the library authors to use polyfilled language features even with Netstandard2.0.

Those libs would also polyfill nullable annotations, which means the Nullable reference could be removed.

Describe the solution you'd like

Using a Polyfilling library

Describe alternatives you've considered

Leaving as is

Additional context

No response

@lukebakken
Copy link
Contributor

Is there something specific that this solves for v7?

@lukebakken lukebakken self-assigned this Sep 26, 2024
@danielmarbach
Copy link
Collaborator Author

See #1687 (comment)

Not strictly necessary but it opens the door for the lifetime of v7 to use newer language features in Netstandard2.0. The alternative is to manually polyfill every use case when it is needed.

@lukebakken
Copy link
Contributor

I'm going to close this since it's not an absolute necessity to ship v7.

@lukebakken lukebakken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants