Oauth2.0_access_token: priority to user parameters #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In oauth2.0_access_token, a user have the possibility to add its own parameters to the POST request. Those parameters are merged with endpoints and app parameters. When a conflict is detected, endpoints parameters are privileged. It makes more sense to prioritize the user parameters to overwrite endpoints parameters.
|
Can you please add a bullet to the top of |
|
Thanks for reviewing this PR, I made the requested changes. |
|
httr has been superseded in favour of httr2, so is no longer under active development. Thanks for using httr, thanks for contributing, and my apologies that your contribution never made it into the package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In oauth2.0_access_token, a user have the possibility to add its own
parameters to the POST request.
Those parameters are merged with endpoints and app parameters.
When a conflict is detected, endpoints parameters are privileged.
It makes more sense to prioritize the user parameters to overwrite
endpoints parameters.
This solve #564 with:
oauth2.0_access_token(endpoint, app, user_params = list(username = "username", password = "password", grant_type = "password"), code = NULL)