Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for full color palette #65

Open
ad-si opened this issue Jul 6, 2018 · 10 comments · May be fixed by #224
Open

Support for full color palette #65

ad-si opened this issue Jul 6, 2018 · 10 comments · May be fixed by #224

Comments

@ad-si
Copy link

ad-si commented Jul 6, 2018

Why is there only support for 16 colors?
The full palette would be cool! 😁

screen shot 2018-07-06 at 17 10 58

@quchen
Copy link
Owner

quchen commented Jun 14, 2019

There’s not enough supply or demand for this feature. ;-)

@quchen quchen closed this as completed Jun 14, 2019
@ad-si
Copy link
Author

ad-si commented Jun 14, 2019

😭

@quchen
Copy link
Owner

quchen commented Jun 16, 2019

You could easily implement this though if you needed it! Just extend data Color by a field RGB Word8 Word8 Word8 and follow the compiler warnings to implement it. ansi-terminal has support for RGB SGR codes (link), so all in all this should not be a hard thing to implement.

I’m very much open to a pull request if you decided to implement this, but at the moment I’m afraid I don’t have the time myself.

@istathar
Copy link

Would you still be amenable to a patch in this direction? I just asked the same question and came to the same https://hackage.haskell.org/package/ansi-terminal-0.10.1/docs/System-Console-ANSI-Types.html#v:SetRGBColor constructor which perhaps we can pass through instead? (I note that it's Colour Float there, which is interesting)

@quchen
Copy link
Owner

quchen commented Oct 18, 2019

Yes, I’m open to it! I’d like to keep the feature small though, without too many color management bells and whistles.

@spacekitteh
Copy link

If @afcowie hasn't got the patch done, I'll do one over the next couple of days.

@istathar
Copy link

@spacekitteh haven't had a chance yet, sorry.

@sjakobi
Copy link
Collaborator

sjakobi commented Jan 24, 2020

Reopening due to the renewed interest.

@quchen
Copy link
Owner

quchen commented Dec 3, 2021

Re-closing due to renewed disinterest ;-)

A PR implementing this would still be welcome though.

@quchen quchen closed this as completed Dec 3, 2021
@sofia-m-a sofia-m-a linked a pull request Apr 25, 2022 that will close this issue
@sjakobi
Copy link
Collaborator

sjakobi commented Apr 25, 2022

Re-re-opening since there is a PR: #224.

@sjakobi sjakobi reopened this Apr 25, 2022
@sjakobi sjakobi linked a pull request Jun 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants