Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go get failing #54

Open
mmellin opened this issue May 14, 2020 · 2 comments
Open

Go get failing #54

mmellin opened this issue May 14, 2020 · 2 comments

Comments

@mmellin
Copy link

mmellin commented May 14, 2020

Hello,

I'm seeing the following while trying to use this library:

$ go get github.com/qri-io/starlib
go: found github.com/qri-io/starlib/re in github.com/qri-io/starlib v0.4.1
go get: github.com/qri-io/[email protected] requires
        github.com/qri-io/[email protected] requires
        github.com/qri-io/[email protected] requires
        github.com/ipfs/[email protected] requires
        github.com/go-critic/[email protected]: invalid pseudo-version: does not match version-control timestamp (2019-02-10T22:04:43Z)

Not sure if this is a local issue on my part or if there is an upstream issue. Please advise.

Environment:

$ go version
go version go1.14.1 darwin/amd64
@charlesdaniels
Copy link

I am seeing this same issue on Linux...

$ go version
go version go1.13.10 linux/amd64

It seems that this is related to this issue with ipfs/go-ipfs, which they have resolved upstream, however qri-io/qfs v0.1.0 still uses the broken version. It looks like HEAD in that repository also uses a newer version of go-ipfs.

This thread on golang-nuts seems to have some relevant discussion and lead me to the workaround below.

Until this issue can be properly resolved by the relevant upstream projects, I have added the following to my go.mod, which seems to have resolved the issue:

replace github.com/go-critic/go-critic v0.0.0-20181204210945-ee9bf5809ead => github.com/go-critic/go-critic v0.4.3

replace github.com/go-critic/go-critic v0.0.0-20181204210945-c3db6069acc5 => github.com/go-critic/go-critic v0.4.3

replace github.com/golangci/errcheck v0.0.0-20181003203344-ef45e06d44b6 => github.com/golangci/errcheck v0.0.0-20181223084120-ef45e06d44b6

replace github.com/golangci/go-tools v0.0.0-20180109140146-af6baa5dc196 => github.com/golangci/go-tools v0.0.0-20190124090046-35a9f45a5db0

replace github.com/golangci/gofmt v0.0.0-20181105071733-0b8337e80d98 => github.com/golangci/gofmt v0.0.0-20190930125516-244bba706f1a

replace github.com/golangci/gosec v0.0.0-20180901114220-66fb7fc33547 => github.com/golangci/gosec v0.0.0-20180901114220-8afd9cbb6cfb

replace github.com/golangci/lint-1 v0.0.0-20180610141402-ee948d087217 => github.com/golangci/lint-1 v0.0.0-20181222135242-d2cdd8c08219

replace mvdan.cc/unparam v0.0.0-20190124213536-fbb59629db34 => mvdan.cc/unparam v0.0.0-20200501210554-b37ab49443f7

Note that I wasn't very scientific in checking those version hashes. I didn't rigorously test starlark under these conditions, so YMMV depending which parts of starlib you are using.

@AlekSi
Copy link
Contributor

AlekSi commented Feb 14, 2021

It works now in modules mode:

$ go get github.com/qri-io/starlib@latest
go: downloading github.com/qri-io/starlib v0.4.2
go: github.com/qri-io/starlib latest => v0.4.2
go: downloading go.starlark.net v0.0.0-20200330013621-be5394c419b6
go: downloading github.com/dustmop/soup v1.1.2-0.20190516214245-38228baa104e
go: downloading github.com/paulmach/orb v0.1.5
go: downloading github.com/PuerkitoBio/goquery v1.5.1
go: downloading golang.org/x/net v0.0.0-20200324143707-d3edc9973b7e
go: downloading github.com/360EntSecGroup-Skylar/excelize v1.4.1
go: downloading github.com/pkg/errors v0.8.1
go: downloading github.com/andybalholm/cascadia v1.1.0
go: downloading gopkg.in/yaml.v2 v2.2.8
go: downloading github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants