Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All mutations to the owner profile must pass through profile.Store.SetOwner() #1884

Open
b5 opened this issue Aug 13, 2021 · 0 comments
Open
Labels
bug code that is not behaving as expected profiles user profile information

Comments

@b5
Copy link
Member

b5 commented Aug 13, 2021

#1882 adds context to the Owner(ctx) method. In an ideal world profile store implementations should be required to store the canonical "Owner" profile in memory, removing the need for any fetching, and by extension the need for a context argument.

We should audit the codebase for owner mutations, return a copy of the profile.Profile in the ProfileStore.Owner() getter method, and add a spec test that assures ProfileStore implementations behave properly with regard to the owner.

Stretch goal: all profile mutations pass through the profile store.

@b5 b5 added bug code that is not behaving as expected profiles user profile information labels Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code that is not behaving as expected profiles user profile information
Projects
None yet
Development

No branches or pull requests

1 participant