Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "pin" arg from dsfs.Save methods #34

Open
b5 opened this issue Dec 20, 2017 · 0 comments
Open

remove "pin" arg from dsfs.Save methods #34

b5 opened this issue Dec 20, 2017 · 0 comments
Assignees
Labels
backlog refactor A code change that neither fixes a bug nor adds a feature

Comments

@b5
Copy link
Member

b5 commented Dec 20, 2017

the pin arg in dsfs save commands is somewhat confusing given that we're trying to push IPFS-specific details into cafs interfaces. The pattern of saving & pinning a dataset should be pushed up to the caller of dsfs.SaveDatatast, who upon successful save should check to see if the store conforms to the Pinner interface, and should then pin the resulting root hash recursively.

@b5 b5 added this to the 0.1.1 milestone Dec 20, 2017
@b5 b5 self-assigned this Dec 20, 2017
@b5 b5 added refactor A code change that neither fixes a bug nor adds a feature ready in progress and removed ready in progress labels Dec 20, 2017
@b5 b5 removed this from the 0.1.1 milestone Feb 5, 2018
@b5 b5 added the backlog label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

No branches or pull requests

1 participant