Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code repetition #90

Open
qixils opened this issue Aug 19, 2022 · 0 comments
Open

Reduce code repetition #90

qixils opened this issue Aug 19, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@qixils
Copy link
Owner

qixils commented Aug 19, 2022

A lot of effects have a lot of needless repetition that could be solved with some abstraction, such as the health commands and especially the enable/disable keep inventory commands. Some more API classes should be created similar to the entity mapper which reduce the repetition of code. If some functionality is too niche to add to the general wrapper API, it could still be abstracted out with, well, an abstract command class. This will likely make a Sponge 9 implementation (if necessary) a lot cleaner and generally make it easier to fix bugs

@qixils qixils added the enhancement New feature or request label Aug 19, 2022
@qixils qixils added this to the 3.4.0 milestone Aug 19, 2022
@qixils qixils self-assigned this Aug 19, 2022
qixils added a commit that referenced this issue Aug 20, 2022
got bored; did some work on #90
@qixils qixils removed this from the 3.3.X milestone Jul 27, 2023
@qixils qixils moved this to In Progress in Minecraft Crowd Control Jul 27, 2023
@qixils qixils moved this from In Progress to Hiatus in Minecraft Crowd Control Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant