Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing in expected values for test acceptance via JSON config #37

Open
iniesC opened this issue Mar 25, 2016 · 5 comments
Open

Passing in expected values for test acceptance via JSON config #37

iniesC opened this issue Mar 25, 2016 · 5 comments

Comments

@iniesC
Copy link

iniesC commented Mar 25, 2016

I would like to pass in expected values to the test being run. The tests can use these values to check the actual output with expected to report pass or fail. Does this support exists?

@wwahammy
Copy link
Contributor

@iniesC I don't think functionality like that exists. I think it'd be a great addition. I think we could put it in the the JSON config file for example. Does that make sense do you think? Also, do you have a recommendation for the format?

@iniesC
Copy link
Author

iniesC commented Mar 29, 2016

@EricSchultz, The JSON format is fine. The goal is to map the testcase with a list of parameters that the test case could use. If no entry is provided in the JSON or no JSON file provided then we pass in defaults that can be used by the tests. Also, we don't have to update the module as we add new tests.

@wwahammy
Copy link
Contributor

@iniesC I think that makes sense. I think we're on the same page here.

Could you expand upon your last sentence though? I'm not sure I understand what you mean by it.

Also, I'm going to update the issue title since this is a feature request.

@wwahammy wwahammy changed the title What is the best way to pass in expected values to the tests Passing in expected values for test acceptance via JSON config Mar 30, 2016
@iniesC
Copy link
Author

iniesC commented Mar 30, 2016

@EricSchultz , I just want this new feature of accepting input values for tests to be robust and flexible in way that it wouldn't require updates when we add or remove tests from BFT.

@wwahammy
Copy link
Contributor

wwahammy commented Apr 8, 2016

@iniesC makes sense. I don't think I have time to work on this myself right now. If you feel comfortable doing a prototype or implementation, I'd be happy to help though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants