Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File checking speed for 4.4.0 is much slower than 4.3.9 #16043

Open
Coresi7 opened this issue Jan 11, 2022 · 90 comments
Open

File checking speed for 4.4.0 is much slower than 4.3.9 #16043

Coresi7 opened this issue Jan 11, 2022 · 90 comments
Labels
Libtorrent Performance Waiting upstream Waiting for changes in dependent libraries
Milestone

Comments

@Coresi7
Copy link

Coresi7 commented Jan 11, 2022

qBittorrent & operating system versions

qBittorrent: 4.3.9 x64
Operating system: Windows server 2022 datacenter 21h1 (10.0.20348)
libtorrent-rasterbar: 1.2.14
qt: 5.15.2

What is the problem?

qbittorrent v4.4.0 with qt6 file check speed is extremely slow, compare to qbittorrent v4.3.9. About 2x slower for hdd, or 10x slower for samba protocol.
require for a fix, thanks!

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

@NoCodeJustPancakes
Copy link

Same issue here, I made no changes other than upgrading program version. 4.3.9 checks files at 400MB/s+ I switch to 4.4.0 check same file, speeds drop to 100MB/s. Reinstall 4.3.9, check file, back to 400MB/s+,

@Cjaker
Copy link

Cjaker commented Jan 15, 2022

Slow check on 4.4.0 and hangs/freeze hardly (feeling of 1~5 FPS on UI)
Downgraded to 4.3.9 and everything is fine

Windows 10 x64 21H2 Build - 19044.1466

@UnviableFriend
Copy link

I'm not sure if this is the cause, but I was just doing a force recheck on a 38GB torrent, and I have 32GB of RAM. I noticed my client became very sluggish and looked over to my task manager to see my memory usage was at 100%. Stopping the recheck completely(just a pause didn't work) and my memory was freed. When I tried again I could see my memory usage climbing as the recheck progressed. Restarting qBittorrent didn't fix the issue and memory usage again kept climbing trying to recheck the torrent.
Windows 10
qBittorrent: 4.4.0
Qt: 5.15.2
Libtorrent: 2.0.5.0
Boost: 1.78.0
OpenSSL: 1.1.1m
zlib: 1.2.11

@captincorpse
Copy link

Same issue here. All I did was update to 4.4.0 and the file recheck is extremely slow now. There may be a memory leak, several times my ram maxed out and qBittorent was using it all. Win 10 with 16Gb ram, qBittorrent was using using 9Gb at one time during file recheck. This started when I noticed a torrent wasn't updating file progress during download. It downloaded over 100Gb of a 150Gb file and showed about 9% done, initiated file recheck and it has been running for 2 hours trying to recheck.

@thalieht
Copy link
Contributor

Is qBittorrent v4.4.0 with Libtorrent 1.2.15 still slower than qBitorrent v4.3.9?

Which can be found here on the bottom https://github.com/qbittorrent/qBittorrent/actions/runs/1665307409
It will probably be back to normal with this version because rechecking is a libtorrent operation.

@Desef

This comment has been minimized.

@linax3-genuine
Copy link

linax3-genuine commented Jan 25, 2022

just verified a 12GB torrent. the hard disk usage was very bad. hdd sounded bad, run at 100% and was doing only reading at very low speed. everything related to that drive was disturbed. 16gb ram almost filled by the process.

...after some testing, reverted to 4.3.9, all the semi-verified torrents verified normally, while seeding multiple torrents. no ram bloating. hdd works and sounds normally, did not even got to 100%, id guess.

@KorbenDls
Copy link

Seeing the same behavior on my system as well on 4.4.1. When checking a torrent, it was maxing out at 7 MB/s. Once I rolled back to 4.3.9 (keeping the same configuration), it's now checking at 220-230 MB/s.

@blackbeard1080
Copy link

Seeing the same behavior on my system as well on 4.4.1. When checking a torrent, it was maxing out at 7 MB/s. Once I rolled back to 4.3.9 (keeping the same configuration), it's now checking at 220-230 MB/s.

Same on 4.4.2 rolled back to 4.3.9

@ghost
Copy link

ghost commented Mar 28, 2022

Can you reproduce this on windows with 4.4.2?

@linax3-genuine
Copy link

im done updating, until this debacle is long gone.
i read other issues and the developers seem to have no clue, of what they are doing.

@Orhideous
Copy link

Also stumbled upon this issue. Was able to reproduce it with 4.4.0, 4.4.1, 4.4.2 versions (libtorrent 2.x)
Changing the number of hashing threads did not bring any results.

How can I help debug this problem?

@tan-wei
Copy link

tan-wei commented Apr 16, 2022

Also for 4.4.2, quite slow for checking a complete torrent.

@tan-wei
Copy link

tan-wei commented Apr 16, 2022

Also stumbled upon this issue. Was able to reproduce it with 4.4.0, 4.4.1, 4.4.2 versions (libtorrent 2.x) Changing the number of hashing threads did not bring any results.

How can I help debug this problem?

I've test 4.3.9~4.4.2, I can confirm it is OK with 4.3.9, but quite slow with other versions.

@Orhideous
Copy link

Compiled qbittorrent-nox from master in two flavors — with libtorrent 1.x and 2.x
Tested on 25G torrent. 1.x version takes ≈7s to rehash, 2.x takes 12-13s. Looks like a problem with libtorrent, not qBittorrent.
@PriitUring

@ghost ghost added the Libtorrent label Apr 20, 2022
@ghost
Copy link

ghost commented Apr 20, 2022

@arvidn ping!

@linax3-genuine
Copy link

Orhideous, it would be nice, if you do the same test on a good old hardware, like what we, mortals use :).
such tests make any flaws quite obvious.

@microka
Copy link

microka commented Apr 20, 2022

I just update to 4.4.2 from 4.3.9, obviously 4.4.2 file checking speed is much more slower than 4.3.9, the files checked are saved on SSD.
So disappointing that 4.4.x are still so much bugs, i am thinking whether should i roll back to 4.3.9.

@microka
Copy link

microka commented Apr 20, 2022

@PriitUring Here is some infomation:
OS: Windows 11 Pro 21H2 x64 (22000.613)
RAM: 16GB*2 + 8GB*1
Files: A folder contains 54 files, each one is 1.x GB and total are 72.4 GB.
Drive Type: SSD

qbittorrent_4.3.9_x64_setup.exe + libtorrent 1.2.14.0 (Default settings): 700+MB/s
qbittorrent_4.4.2_x64_setup.exe + libtorrent 2.0.5.0 + Physical memory (RAM) usage limit: 512MB (Default Value): 310+MB/s
qbittorrent_4.4.2_x64_setup.exe + libtorrent 2.0.5.0 + Physical memory (RAM) usage limit: 16384MB : 380+MB/s
qbittorrent_4.4.2_x64_setup.exe + libtorrent 2.0.5.0 + Physical memory (RAM) usage limit: 32768MB : 380+MB/s
qbittorrent_4.4.2_RC_1_2_qt5_x64_setup.exe + libtorrent 1.2.15.0 + Physical memory (RAM) usage limit: 512MB (Default Value): 700+MB/s

I think libtorrent 2.x is the cause of the problem.

@microka
Copy link

microka commented Apr 20, 2022

The tests i ran above is extract the setup .exe file using 7-zip, and create a 'profile' folder to run qBittorrent with default settings in portable mode, each one test only 1 single torrent.

  1. v4.3.9 (Qt 5.15.2 + libtorrent 1.2.14.0) vs v4.4.2 (Qt 5.15.2 + libtorrent 2.0.5.0), the two test results I'have already posted. But i don't know how to run the 'latest v4.4.x branch build with Qt5 and libtorrent 1.2.15+' in portable mode.

  2. v4.3.9 with Qt5 and libtorrent 1.2.14+ vs v4.4.2 and latest v4.4.x with Qt5 and libtorrent 2.0.5+
    except latest v4.4.x, other results already posted.

  3. I don't know how to get "latest GitHub v4.4.x branch build of qBittorrent with libtorrent 2.0.5+"

@microka
Copy link

microka commented Apr 26, 2022

Is there any progress?

@NoCodeJustPancakes
Copy link

Easiest fix: Download 4.3.9 and disable 'Check for program updates' ¯(°_o)/¯

@microka
Copy link

microka commented Apr 28, 2022

Yep! I had downgraded to v4.3.9, everything works fine.

@tan-wei
Copy link

tan-wei commented Apr 28, 2022

Quite slow. 400 torrents will cost 2 days. But for v4.3.9, several hours are enough.

@arvidn
Copy link
Contributor

arvidn commented Apr 28, 2022

do the libtorrent-1.2.x and libtorrent-2.0.x tests use the same number of threads to hash with? (this is the aio_threads setting).

If it's hard to tell, when looking at activity monitor, does one peg more CPU cores than the other?

@arvidn
Copy link
Contributor

arvidn commented Apr 28, 2022

so maybe fewer aio_threads would be better in 2.0.x. it would probably increase "sequentiality"

@Pentaphon

This comment was marked as off-topic.

@arvidn
Copy link
Contributor

arvidn commented Aug 14, 2022

would anyone be interested in giving this a try? arvidn/libtorrent#7013

it's in master because the disk code has diverged quite a bit from 2.0

@microka

This comment was marked as spam.

@glassez
Copy link
Member

glassez commented Aug 15, 2022

would anyone be interested in giving this a try? arvidn/libtorrent#7013

👍
Will do.

@ghost
Copy link

ghost commented Aug 24, 2022

Please test v4.4.4, it should take care of the GUI stuttering issue.

@DanielSmedegaardBuus

This comment was marked as off-topic.

@DanielSmedegaardBuus

This comment was marked as off-topic.

@linax3-genuine

This comment was marked as off-topic.

@DanielSmedegaardBuus

This comment was marked as off-topic.

@linax3-genuine

This comment was marked as off-topic.

@DanielSmedegaardBuus
Copy link

this is the only thing that i understood, after anything you have said: "I'll stay out of this thread now.". i hope the linux, or other people understood you better.

Oh, wow. That's some next-level poor social skills there. You do realize that you're on a Github issues board, right? This is a place for developers (like myself) and users (also like myself in this case) to interact on work on issues with the code. So when you read something you don't understand, you don't have to tell everyone about it. Better to just ignore it. As someone once said, "Better to remain silent and be thought a fool than to open your mouth and remove all doubt."

As for the general attitude, cheers on adding to the thread's — and by extension the Issues section's — apparent toxicity. I hope you get happier and better at interacting, I really do. It'll be better for you and the people that come in contact with you.

Cheers

@baccccccc
Copy link

baccccccc commented Aug 27, 2022

Please test v4.4.4, it should take care of the GUI stuttering issue.

Unfortunately, I don't see much improvement here. GUI performance still noticeably decrease over time, and I have to restart the app 1-2 times a day. If I don't, then after 2+ days it becomes completely unresponsive. In addition, all 8 cores of my CPU keep at almost 100% all the time. (Needless to say, that's not the case when qBitTorrent is not running.)

Is there any setting I have to change?

(64-bit qBittorrent v.4.4.4 official build, Qt 6.3.0 and Libtorrent 2.0.7.0. Windows 11 x64 on a VM, using 8 cores CPU and 14 GB dedicated RAM. Hashing threads option is set to 1.)

@glassez

This comment was marked as off-topic.

@Pentaphon
Copy link

Now that 4.4.5 went back to v1, how's everybody's performance on that release?

@mazzz1y
Copy link

mazzz1y commented Sep 17, 2022

Now that 4.4.5 went back to v1, how's everybody's performance on that release?

the same for me

my fault, I compilled it with libtorrent 2.0

@ghost ghost unpinned this issue Sep 17, 2022
@xinmans
Copy link

xinmans commented Jan 26, 2023

Same issue here, i use 4.5.0, but checking very slow, what happened?

qBittorrent v4.5.0 Web UI (64-bit)
Qt: | 6.4.1
Libtorrent: | 2.0.8.0
Boost: | 1.81.0
OpenSSL: | 3.0.7
zlib: | 1.2.13

@Pentaphon
Copy link

i use 4.5.0, but checking very slow, what happened?

Use the libtorrent 1.2 version instead.

@xinmans
Copy link

xinmans commented Jan 26, 2023

i use 4.5.0, but checking very slow, what happened?

Use the libtorrent 1.2 version instead.

which docker image https://hub.docker.com/r/linuxserver/qbittorrent/tags?page=1

this one:4.5.0-libtorrentv1 ?

@Pentaphon
Copy link

this one:4.5.0-libtorrentv1 ?

I think so? Anything labeled v1.2.18 instead of v2.0.8

@xinmans
Copy link

xinmans commented Jan 26, 2023

this one:4.5.0-libtorrentv1 ?

I think so? Anything labeled v1.2.18 instead of v2.0.8
Yes, but checking speed seems not faster

Qt: | 6.4.2
Libtorrent: | 1.2.18.0
Boost: | 1.81.0
OpenSSL: | 3.0.7
zlib: | 1.2.12.zlib-ng

@IRainman
Copy link

It's probably already fixed by added additional buffer to the hasher?

@Safari77
Copy link

It's probably already fixed by added additional buffer to the hasher?

All downloads are paused while the files are being checked. Maybe it needs a redesign.

@yueisme
Copy link

yueisme commented May 12, 2024

#16043 (comment)

change aio_threads can't feel effective, i recommend setting hashing_threads to 1 for HDD, higher for SSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Libtorrent Performance Waiting upstream Waiting for changes in dependent libraries
Projects
None yet
Development

No branches or pull requests