Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTCP Version response #87

Open
llmII opened this issue Feb 16, 2021 · 2 comments
Open

CTCP Version response #87

llmII opened this issue Feb 16, 2021 · 2 comments

Comments

@llmII
Copy link
Contributor

llmII commented Feb 16, 2021

The current CTCP Version response is go-ircevent $version. Should we change this to respond that we're actually go-discord-irc $version and how would the version be pulled (since there isn't an actual release that I know of and thus it would all be git commit refs?).

@qaisjp
Copy link
Owner

qaisjp commented Feb 18, 2021

This project isn't versioned, so commit sha would work.

To be quite honest, I'm not particularly bothered with this, but if you çare about it & can find a nice solution that works with the Git commit, sure!

It might also be useful for https://hub.docker.com/r/qaisjp/go-discord-irc.

@llmII
Copy link
Contributor Author

llmII commented Feb 18, 2021

I'm more just unsure how to get a commit sha into go code. I'd guess the Makefile could execute a command to replace a certain thing inside a version.go file on build where if git isn't used it'd just fall back to "go-discord-irc version: Unknown" or something. That said, there may be a better way to do it than to edit then reset a file.

I'll look into this eventually. Sort of keeping track of things I may attempt to work on, but if anyone beats me to it that's awesome! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants