Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image TrimSec #342

Open
GermanHydrogen opened this issue Feb 5, 2024 · 1 comment
Open

Image TrimSec #342

GermanHydrogen opened this issue Feb 5, 2024 · 1 comment

Comments

@GermanHydrogen
Copy link
Contributor

Applying the TRIMSEC header to the data, seems like a good candidate for the Image class.
This is currently implemented in ProjectedOffsets:

pyobs-core/pyobs/images/processors/offsets/projected.py

Line 86 in d5f7952

if "TRIMSEC" in hdr:

@GermanHydrogen
Copy link
Contributor Author

I would suggest a signature def trim(self) -> Image
There would be two possibilities implementing that:

  1. We write something ourself
  2. We could convert the Image to CCDData, use the trim_image method, and convert back. This would be the easier possibility, but would add a dependence to ccdproc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GermanHydrogen