You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe
There's a multitude of ways one could download a file with curl/wget. Currently the only options e.g. curl uses in files.download() is -sSLf.
As an example, when downloading the Rust installer, they suggest to add curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs when using curl.
This is not currently possible to do, since files.download() doesn't take additional curl arguments.
Describe the solution you'd like
Add the curl/wget arguments to files.download(..., curl_args: list[Union[str, StringCommand]] = ["-sSLf"], wget_args: list[Union[str, StringCommand]] = ["-q"]) instead, and default them to the args that would be normally set.
Or add them as optional arguments, and update the default args to be passed to curl/wget. Whichever you think would be better. I would prefer the default arguments, because then the control is given to the user instead.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe
There's a multitude of ways one could download a file with curl/wget. Currently the only options e.g. curl uses in
files.download()
is-sSLf
.As an example, when downloading the Rust installer, they suggest to add
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs
when using curl.This is not currently possible to do, since
files.download()
doesn't take additional curl arguments.Describe the solution you'd like
Add the curl/wget arguments to
files.download(..., curl_args: list[Union[str, StringCommand]] = ["-sSLf"], wget_args: list[Union[str, StringCommand]] = ["-q"])
instead, and default them to the args that would be normally set.Or add them as optional arguments, and update the default args to be passed to curl/wget. Whichever you think would be better. I would prefer the default arguments, because then the control is given to the user instead.
The text was updated successfully, but these errors were encountered: