Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum puppet version for puppetlabs-kubernetes 7.1.1 #658

Open
XSpielinbox opened this issue Sep 24, 2023 · 1 comment
Open

Minimum puppet version for puppetlabs-kubernetes 7.1.1 #658

XSpielinbox opened this issue Sep 24, 2023 · 1 comment

Comments

@XSpielinbox
Copy link

Describe the Change You Would Like

On the Puppet Forge, for version 7.1.1 the minimum Puppet version is stated as 7.24.0, whereas for 7.1.0 it only was 6.24.0. To bump the minimum version requirement by a major version in a patch release is pretty insane in my opinion and forbidden by semantic versioning.
The changelog also does not state anything related to this change. The dropping of support for Puppet 6 is stated in the changelog for verison 8.0.0.

Could it be that this is a typo in version 7.1.1?

@deric
Copy link
Collaborator

deric commented Feb 22, 2024

The change has been done in #626, resp. 75f5dc7. You're right it should have been part of major release.

has_key function was part of stdlib < 9.0.0 puppetlabs/puppetlabs-stdlib@f629f7b but the in operator should be working with Puppet 6. With removal of has_key it's possible to update the requirement puppetlabs-stdlib < 10.0.0, but Puppet version requirement doesn't have to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants