-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyring File Modification Date Incorrectly Updated #1196
Comments
GitHub.com doesn't provide any of the HTTP headers that Puppet's You would need to provide the checksum, but this needs to be passed through to here, so we need a pull request: puppetlabs-apt/manifests/keyring.pp Lines 54 to 61 in 9b6aa36
By the way, no need to use |
puppetlabs#1196 * Adds checksum and checksum_value parameter to apt::keyring, this should address issue/1196 as commented here puppetlabs#1196 (comment) * Includes tests, all green.
Hello, I've written the PR as suggested by @kenyon But sadly, it did not do the intended fix. I believe this also would require to alter the puppet File type itself. |
Hum, doing so:
That looks more like a workaround rather than a fix that would be to serve the file from some reliable/dependable source where some sane headers can be used to make sure a file is up-to-date or not. |
puppetlabs#1196 * Adds checksum and checksum_value parameter to apt::keyring, this should address issue/1196 as commented here puppetlabs#1196 (comment) * Includes tests, all green.
Sadly not every source maintainer is doing that effort ( e.g. packager.io - which caused me to look up solutions to this issue in the first place). We cannot depend/rely on the assumption that the source will provide this. I agree it's a workaround, and that the real fix is at the source, however for the sake of idempotency and thus not causing needless changes and their follwing triggers (This basically causes |
Oh, sorry, BTW: |
Meanwhile, I'm starting to think that |
@jay7x there was some discussion of that in puppetlabs/puppet#9319. |
Bug
The keyring file /etc/apt/keyrings/percona unexpectedly has its modification date (mtime) altered every time the Puppet catalog is applied. this behavior is inconsistent with expected behavior, where the content should only change if the file content is actually modified.
Steps to Reproduce
Apply the Puppet catalog that includes the server::apt::sources configuration.
Environment
Additional Context
It doesn't show changes when I change the timestamp of key files to future.
touch -d "2124-08-29 12:53:46 +0200" /etc/apt/keyrings/*
The text was updated successfully, but these errors were encountered: