-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prancible] I5492 add friendly names to ufw #5500
Open
VickieKarasic
wants to merge
5
commits into
main
Choose a base branch
from
i5492
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VickieKarasic
commented
Nov 4, 2024
group_vars/all/vars.yml
Outdated
- 172.20.80.0/22 #PU Subnet - LibNetPvt | ||
- 172.20.95.0/24 #Princeton VPN Subnet 1 | ||
- 172.20.192.0/19 #Princeton VPN Subnet 2 | ||
ufw_libnet: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should come up with a new name?
- ufw_public_library_servers
- or, document what libnet means
CI is failing with |
Merged
kayiwa
force-pushed
the
i5492
branch
3 times, most recently
from
December 20, 2024 13:08
a5155ec
to
9fcc68e
Compare
kayiwa
force-pushed
the
i5492
branch
2 times, most recently
from
December 20, 2024 18:46
e1498cc
to
e06a8b4
Compare
Co-authored-by: Alicia Cozine <[email protected]> Co-authored-by: Francis Kayiwa <[email protected]>
Co-authored-by: Alicia Cozine <[email protected]> Co-authored-by: Francis Kayiwa <[email protected]>
we have elected to define networks in IT-Handbook added clearer examples that use this #5559 Our previous values matched a format that is no longer true Co-authored-by: Vickie Karasic <[email protected]>
include documentation on how to use the role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5492 - creates variables in the group_vars/all for use in ufw_firewall to represent the relevant network segments.