Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prancible] I5492 add friendly names to ufw #5500

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

VickieKarasic
Copy link
Contributor

@VickieKarasic VickieKarasic commented Nov 1, 2024

Closes #5492 - creates variables in the group_vars/all for use in ufw_firewall to represent the relevant network segments.

@VickieKarasic VickieKarasic changed the title I5492 [prancible] I5492 add friendly names to ufw Nov 1, 2024
- 172.20.80.0/22 #PU Subnet - LibNetPvt
- 172.20.95.0/24 #Princeton VPN Subnet 1
- 172.20.192.0/19 #Princeton VPN Subnet 2
ufw_libnet:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should come up with a new name?

  • ufw_public_library_servers
  • or, document what libnet means

@acozine
Copy link
Contributor

acozine commented Nov 8, 2024

CI is failing with 'ufw_campus_and_vpn' is undefined. We need a default value in the role for testing purposes, since Molecule does not load anything from group_vars.

@acozine acozine marked this pull request as draft November 11, 2024 17:37
@kayiwa kayiwa mentioned this pull request Dec 2, 2024
@kayiwa kayiwa force-pushed the i5492 branch 3 times, most recently from a5155ec to 9fcc68e Compare December 20, 2024 13:08
@kayiwa kayiwa force-pushed the i5492 branch 2 times, most recently from e1498cc to e06a8b4 Compare December 20, 2024 18:46
@kayiwa kayiwa marked this pull request as ready for review December 20, 2024 18:47
VickieKarasic and others added 4 commits December 20, 2024 13:53
Co-authored-by: Alicia Cozine <[email protected]>
Co-authored-by: Francis Kayiwa <[email protected]>
Co-authored-by: Alicia Cozine <[email protected]>
Co-authored-by: Francis Kayiwa <[email protected]>
we have elected to define networks in IT-Handbook
added clearer examples that use this #5559

Our previous values matched a format that is no longer true

Co-authored-by: Vickie Karasic <[email protected]>
include documentation on how to use the role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modify our firewall rules to have network names
3 participants