From 72a310fc72e67f9943a73536ef48c6d132af1ca5 Mon Sep 17 00:00:00 2001
From: 20LM22 <46831359+20LM22@users.noreply.github.com>
Date: Fri, 2 Aug 2024 15:42:47 -0400
Subject: [PATCH] adding header changes (#1883)

---
 app/assets/stylesheets/application.scss |  9 ++++
 app/views/shared/_header.html.erb       | 18 +++++--
 spec/system/front_page_spec.rb          |  1 -
 spec/views/_header.html.erb_spec.rb     | 65 +++++++++++++++++++++++++
 4 files changed, 87 insertions(+), 6 deletions(-)
 create mode 100644 spec/views/_header.html.erb_spec.rb

diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss
index c75d55c7f..039047852 100644
--- a/app/assets/stylesheets/application.scss
+++ b/app/assets/stylesheets/application.scss
@@ -20,6 +20,15 @@
 @import "components/users.scss";
 @import "components/nav.scss";
 
+
+#pdc-discovery-label {
+  float: left;
+  margin: 0 auto;
+  height: 40px;
+  line-height: 40px;
+  text-align: center;
+}
+
 .welcome-headers, #welcome-to-pdc {
   font-size: 2rem !important;
 }
diff --git a/app/views/shared/_header.html.erb b/app/views/shared/_header.html.erb
index 133ade51a..406f58aec 100644
--- a/app/views/shared/_header.html.erb
+++ b/app/views/shared/_header.html.erb
@@ -5,11 +5,19 @@
       <% if current_user && (current_user.super_admin? || current_user.moderator?) %>
         <%= render 'shared/admin_actions' %>
       <% end %>
-      <nav id="menu" class="col-sm" role="menu">
-        <%= link_to "About","#{root_url}about", :class => "btn btn-primary about", :role => "menuitem" %>
-        <%= link_to "How to Submit", "#{root_url}#how-to-submit", :class => "btn btn-primary how-to-submit", :role => "menuitem" %>
-        <%= link_to "Help", "#{root_url}help", :class =>"btn btn-secondary help", :role => "menuitem" %>
-      </nav>
+      <% if current_user %>
+        <nav id="menu" class="col-sm" role="menu">
+          <%= link_to "How to Submit", "#{root_url}#how-to-submit", :class => "btn btn-primary how-to-submit", :role => "menuitem" %>
+          <%= link_to "Need Help?", "#{root_url}help", :class =>"btn btn-secondary help", :role => "menuitem" %>
+        </nav>
+      <% else %>
+        <div id="pdc-discovery-label">Looking for data? Go to</div>
+        <nav id="menu" class="col-sm" role="menu">
+          <%= link_to "Princeton Data Commons: Discovery","https://datacommons.princeton.edu/discovery/", :class => "btn btn-primary about", :role => "menuitem" %>
+          <%= link_to "How to Submit", "#{root_url}#how-to-submit", :class => "btn btn-primary how-to-submit", :role => "menuitem" %>
+          <%= link_to "Need Help?", "#{root_url}help", :class =>"btn btn-secondary help", :role => "menuitem" %>
+        </nav>
+      <% end %>
       <nav id="user-actions" class="col-sm">
         <% if current_user %>
         <%= render 'shared/user_actions' %>
diff --git a/spec/system/front_page_spec.rb b/spec/system/front_page_spec.rb
index 25c163af0..6a51c6988 100644
--- a/spec/system/front_page_spec.rb
+++ b/spec/system/front_page_spec.rb
@@ -9,7 +9,6 @@
 
   it "has a header with links to helpful info" do
     visit "/"
-    expect(page).to have_link "About", href: /about/
     expect(page).to have_link "How to Submit", href: /how-to-submit/
   end
 
diff --git a/spec/views/_header.html.erb_spec.rb b/spec/views/_header.html.erb_spec.rb
new file mode 100644
index 000000000..ed1010008
--- /dev/null
+++ b/spec/views/_header.html.erb_spec.rb
@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+require "rails_helper"
+
+describe "header", type: :system do
+  context "for logged-out users" do
+    it "renders the correct links on homepage" do
+      visit "/"
+      expect(page).to have_link("Princeton Data Commons: Discovery", href: "https://datacommons.princeton.edu/discovery/")
+      expect(page).to have_selector(:link_or_button, "How to Submit")
+      expect(page).to have_selector(:link_or_button, "Need Help?")
+      expect(page).to have_selector(:link_or_button, "Log In")
+    end
+
+    it "renders the correct links on help page" do
+      visit "/help"
+      expect(page).to have_link("Princeton Data Commons: Discovery", href: "https://datacommons.princeton.edu/discovery/")
+      expect(page).to have_selector(:link_or_button, "How to Submit")
+      expect(page).to have_selector(:link_or_button, "Need Help?")
+      expect(page).to have_selector(:link_or_button, "Log In")
+    end
+  end
+
+  context "for logged-in users" do
+    let(:user) { FactoryBot.create :princeton_submitter }
+
+    before do
+      login_as user
+    end
+
+    it "renders the correct links on homepage" do
+      visit "/"
+      expect(page).to have_selector(:link_or_button, "How to Submit")
+      expect(page).to have_selector(:link_or_button, "Need Help?")
+      expect(page).to have_selector(:link_or_button, user.uid.to_s)
+    end
+
+    it "renders the correct links on help page" do
+      visit "/help"
+      expect(page).to have_selector(:link_or_button, "How to Submit")
+      expect(page).to have_selector(:link_or_button, "Need Help?")
+      expect(page).to have_selector(:link_or_button, user.uid.to_s)
+    end
+
+    it "renders the correct links on notifications page" do
+      visit "/work_activity_notifications"
+      expect(page).to have_selector(:link_or_button, "How to Submit")
+      expect(page).to have_selector(:link_or_button, "Need Help?")
+      expect(page).to have_selector(:link_or_button, user.uid.to_s)
+    end
+
+    it "renders the correct links on profile page" do
+      visit "/users/#{user.uid}/edit"
+      expect(page).to have_selector(:link_or_button, "How to Submit")
+      expect(page).to have_selector(:link_or_button, "Need Help?")
+      expect(page).to have_selector(:link_or_button, user.uid.to_s)
+    end
+
+    it "renders the correct links on dashboard page" do
+      visit "users/#{user.uid}"
+      expect(page).to have_selector(:link_or_button, "How to Submit")
+      expect(page).to have_selector(:link_or_button, "Need Help?")
+      expect(page).to have_selector(:link_or_button, user.uid.to_s)
+    end
+  end
+end