-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding a move to top icon #597
Comments
Hi @limzykenneth, @lmccart, @kjhollen I'd like to discuss the implementation of the "Move to Top" button for the site. I’ve created a component for it and used SCSS for styling, but before submitting a new PR, I want to gather feedback to ensure it aligns with our overall design and approach. Here are a few points for discussion: Feature Necessity — Do we think this button would add value to the user experience? If not, we can close the issue. Thanks! |
Just in terms of the styling method (not commenting on the necessity and design aspects at the moment), many of the styling that we use on the website uses TailwindJS and not necessarily SCSS. Tailwind can help reduce the overall code duplication in CSS so I would prefer to use it where possible, so this should be looked into. |
Hi @limzykenneth, thank you for your feedback! I understand your point about preferring TailwindCSS for styling consistency across the project. Before I go ahead and refactor the implementation to use Tailwind, I wanted to clarify if it would be better to first discuss the necessity and design of this feature in more detail. Please let me know how you'd like to proceed, and I'm happy to make any adjustments based on the project’s needs. Thanks for guiding me through this! |
Yes, there need to be some discussion and research into the necessity and design. For example (not the only thing to determine), should go to top button be animating to the top or just jumps to it? Should it use a |
Hi @limzykenneth thank you for clarifying! I understand now that we need to discuss the specific design and implementation details before proceeding. For example, as you mentioned, whether the button should animate smoothly to the top or just jump, and whether to use an #id or JavaScript for scrolling behavior. I agree it’s important to align this with the overall design approach of the website. |
Using this issue is fine |
Hi @limzykenneth , I hope you’re doing well! I wanted to check with you before proceeding further. Based on the discussions, we’ve established that there are multiple considerations for implementing the "Move to Top" button feature, such as:
Looking forward to your advice! Let me know if there’s anything else you’d like to clarify before I proceed. Best regards, |
Increasing Access
this will reduce the time to scroll back at top
Most appropriate sub-area of p5.js?
Home
Feature request details
makes the site more user friendly
The text was updated successfully, but these errors were encountered: