Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit names on SketchList or CollectionList using keyboard controls #2383

Closed
lindapaiste opened this issue Aug 16, 2023 · 2 comments · Fixed by #3150
Closed

Cannot edit names on SketchList or CollectionList using keyboard controls #2383

lindapaiste opened this issue Aug 16, 2023 · 2 comments · Fixed by #3150
Assignees
Labels
Area:Accessibility Category for accessibility related features and bugs Bug

Comments

@lindapaiste
Copy link
Collaborator

lindapaiste commented Aug 16, 2023

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

The name turns into an input, but immediately closes.

This is because the "Enter" keyboard event which was used to select "Rename" is still being processed, and "Enter" will submit the form.

Expected Behavior

The name should turn into an input and stay that way until you press "Enter" again.

Steps to reproduce

Steps:

  1. Go to your /sketches page.
  2. Click somewhere on the page to focus.
  3. Press "Tab" until you focus on the dropdown at the end of the table row.
    image
  4. Press "Enter" to open the dropdown.
  5. Press "Tab" to focus on "Rename".
    image
  6. Press "Enter" to select "Rename".
  7. Try to edit the name...you can't.

I came across this issue while working on #2382 and it will be fixed in that PR. We could also implement a more immediate fix for just this issue if we deem it high-priority.

@lindapaiste lindapaiste added Area:Accessibility Category for accessibility related features and bugs Bug labels Aug 16, 2023
@lindapaiste lindapaiste self-assigned this Aug 16, 2023
@gajanandh
Copy link

hi @lindapaiste  ,I would like to fix this issue can you please assign it to me..?

gajanandh added a commit to gajanandh/p5.js-web-editor that referenced this issue Sep 5, 2023
@Ankush263
Copy link
Contributor

Hey @lindapaiste, I solved this issue locally, should I raise a PR??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs Bug
Projects
None yet
4 participants