Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltipv2: Fix TooltipV2 docs iframe #5471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tooltipv2: Fix TooltipV2 docs iframe #5471

wants to merge 1 commit into from

Conversation

TylerJDev
Copy link
Contributor

It was mentioned that our storybook examples in our docs weren't working properly. This PR fixes that by adding "v2" to the ids for TooltipV2.

Changelog

Changed

  • Fix TooltipV2 Storybook ids

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why (Storybook only)

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: aa3d3dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.77 KB (0%)
packages/react/dist/browser.umd.js 104.1 KB (0%)

@TylerJDev TylerJDev marked this pull request as ready for review December 20, 2024 17:18
@TylerJDev TylerJDev requested a review from a team as a code owner December 20, 2024 17:18
@TylerJDev TylerJDev requested a review from jonrohan December 20, 2024 17:18
@TylerJDev TylerJDev enabled auto-merge December 20, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TylerJDev