Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack does not properly forward ref #5446

Open
iansan5653 opened this issue Dec 16, 2024 · 1 comment
Open

Stack does not properly forward ref #5446

iansan5653 opened this issue Dec 16, 2024 · 1 comment
Labels
bug Something isn't working component: Stack react

Comments

@iansan5653
Copy link
Contributor

Stack appears to accept a ref prop based on the TypeScript types, but this ref is not actually bound to the underlying element:

export function Example() {
  const ref = useRef<HTMLDivElement>(null)

  useEffect(() => console.log(ref.current))

  return <Stack {...props} ref={ref}>contents</Stack>
}

If Stack correctly forwarded its ref, the console would log an HTMLDivElement instance. However, it instead always logs null.

@Jaykhanderay
Copy link

import React, { forwardRef } from "react";

const Stack = forwardRef((props, ref) => {
return (
<div {...props} ref={ref}>
{props.children}

);
});

export default Stack;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: Stack react
Projects
None yet
Development

No branches or pull requests

2 participants