-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token
sizes and icons don't align with other controls
#5203
Comments
Uh oh! @iansan5653, the image you shared is missing helpful alt text. Check your issue body. Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
Token
sizes don't align with other control sizesToken
sizes and icons don't align with other controls
Sorry I was testing SelectPanel in review lab 😅 Ignore assignments please. |
Token
has asize
prop which accepts standard size names likesmall
andmedium
. These sizes, however, don't correspond with other Primer components, making it difficult to integrate token components into a design.For example, here is a set of
medium
tokens with amedium
IconButton
:Note how the icon button and the tokens do not align at all. And even though the tokens are small, their "x" buttons are larger, exacerbating the problem further.
I would expect that tokens would render with a height that matches the corresponding
--control-size
variable for the size they are rendered with, and with icons that match the corresponding size ofIconButton
.The text was updated successfully, but these errors were encountered: