-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Add an explicit aria-label
to SubTree ul
elements for Safari VoiceOver support
#5035
Comments
Thanks for letting us know! We're actively working on PRC accessibility remediation right now in https://github.com/github/primer/issues/3453. @TylerJDev should we add this Sev 2 to https://github.com/github/primer/issues/3555, assuming this issue hasn't already been catalogued? |
@lesliecdubs, yes we can! I've added this in the batch linked, under severity-2 issues. Should be able to tackle this alongside the other |
@strackoverflow, I've created a PR (#5174) that adds |
@TylerJDev thanks! Yeah, I'm not sure how we could do this automatically either. I wonder if just using the parent item's full accessible name on the list would be enough to unblock the VoiceOver issue? |
@strackoverflow, we could! I'm thinking this might cause some redundancy since I believe it'll repeat the item it was last on, at least for other SRs 🤔 Tagging @ericwbailey for any additional thoughts! |
I thiiiiiiiiiink NVDA and JAWS' heuristics will only single announce if the string and the Happy to check this out with AT if there's a place I can access outside of the github/github org. |
Sorry for the delay here! I'll follow up with the guidance here, and test with NVDA/JAWS! |
|
Bjkvjjnjij |
/ |
Description
This came up from an accessibility audit of one of our internal components which makes use of TreeView. (GitHub staff link for more context: https://github.com/github/collaboration-workflows-flex/issues/1190).
It looks like the
TreeView.SubTree
component needs anaria-label
on itsul
element in order for Safari's VoiceOver screenreader to properly describe the nested list. This label should just be equivalent to the parent item's accessible name.This seems like something we could automatically set on all SubTrees so they are VoiceOver compatible, but if there's some reason why we wouldn't want to do this across the board, we could at least add a prop to pass in an
aria-label
to the SubTree. I'm curious to hear if there's an opinion one way or the other on that 🤔Steps to reproduce
Version
v36.27.0
Browser
Safari
The text was updated successfully, but these errors were encountered: