Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item flicker fix in bugs_and_glitches.md is outdated and incomplete #1215

Open
ExpoSeed opened this issue Oct 1, 2020 · 3 comments · Fixed by #1688
Open

Item flicker fix in bugs_and_glitches.md is outdated and incomplete #1215

ExpoSeed opened this issue Oct 1, 2020 · 3 comments · Fixed by #1688

Comments

@ExpoSeed
Copy link
Contributor

ExpoSeed commented Oct 1, 2020 •
edited
Loading

This fix contains a reference to an undocumented field that has since been documented, and is also dependent on this fix which should be referenced:
DiscordCanary_qBjVwDBDHX

Without including the above, the doc fix as is produces the following result:
broken fix
@ExpoSeed ExpoSeed changed the title Item flicker fix in bugs_and_glitches.md is outdated Item flicker fix in bugs_and_glitches.md is outdated and incomplete Oct 1, 2020
@ShinyDragonHunter
Copy link
Contributor

I’m gonna address as I go through and edit bugs_and_glitches.md

@GriffinRichards
Copy link
Member

See also #1514

@rawr51919 rawr51919 mentioned this issue Jun 10, 2022
Closed
@rawr51919 rawr51919 mentioned this issue Jun 17, 2022
Merged
@LOuroboros
Copy link
Contributor

Actually #1688 didn't fix the issue.

pn_20220704_2004133.mp4

The video above was recorded in an up-to-date and clean copy of Pokeemerald, with #define BUGFIX enabled.

The original author of the fix (ShinyDragonHunter aka Josh) suggested an extra change, but it didn't change anything.

This ticket should probably be re-opened 👀

antoinejen pushed a commit to antoinejen/pokeemerald that referenced this issue Jul 18, 2022
@rawr51919
Add bugfix from bugs_and_glitches.md to BUGFIX
4e0e908 
Item flicker fix now in `BUGFIX`
Supersedes and resolves pret#1680
Fixes pret#1215
Fixes pret#1514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bugfix from bugs_and_glitches.md to BUGFIX
Fix item menu flicker fix documentation
4 participants
@LOuroboros @GriffinRichards @ShinyDragonHunter @ExpoSeed